Skip to content
This repository was archived by the owner on Sep 17, 2024. It is now read-only.

chore: bump helm versions#874

Merged
mdelapenya merged 5 commits intoelastic:masterfrom
mdelapenya:747-bump-helm
Mar 16, 2021
Merged

chore: bump helm versions#874
mdelapenya merged 5 commits intoelastic:masterfrom
mdelapenya:747-bump-helm

Conversation

@mdelapenya
Copy link
Copy Markdown
Contributor

@mdelapenya mdelapenya commented Mar 10, 2021 •
edited
Loading

What does this PR do?

It bumps versions for Helm test suite:

  • Elastic Helm charts: from 7.10.0 to 7.11.1
  • Helm: from 3.4.1 to 3.5.2
  • Kind: from 0.8.1 to 0.10.0

We also found that filebeat uses a daemonset for deployment, exactly as metricbeat does. We updated the code that calculated the resource name to match the new behaviour. For further information, please see the original PR that added that change.

Why is it important?

Test latest versions

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the Unit tests for the CLI, and they are passing locally
  • I have run the End-2-End tests for the suite I'm working on, and they are passing locally
  • I have noticed new Go dependencies (run make notice in the proper directory)

Author's Checklist

  • @jmlrt are versions correct?

How to test this PR locally

SUITE="helm" DEVELOPER_MODE=false TIMEOUT_FACTOR=1 LOG_LEVEL=TRACE ELASTIC_APM_ACTIVE=true make -C e2e functional-test

Related issues

@mdelapenya mdelapenya self-assigned this Mar 10, 2021
@mdelapenya mdelapenya requested review from a team and jmlrt March 10, 2021 16:40
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Mar 10, 2021 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #874 updated

  • Start Time: 2021-03-15T11:14:34.087+0000

  • Duration: 34 min 21 sec

  • Commit: 138cf06

Test stats 🧪

Test Results
Failed 0
Passed 109
Skipped 0
Total 109

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 109
Skipped 0
Total 109

@mdelapenya
fix: support filebeat deployment
d443ebd 
elastic/helm-charts#964 introduced the feature of
deploying a Kubernetes deployment instead of a Daemonset using Filebeat,
using a values.yaml syntax equivalent to Metricbeat
mdelapenya
mdelapenya commented Mar 11, 2021
View reviewed changes
Comment thread e2e/_suites/helm/helm_charts_test.go
return strings.ToLower(ts.Name + "-" + ts.Name + "-cluster-role-binding")
} else if resource == k8s.ResourceTypes.ConfigMap {
if ts.Name == "metricbeat" {
if ts.Name == "filebeat" || ts.Name == "metricbeat" {
Copy link
Copy Markdown
Contributor Author

@mdelapenya mdelapenya Mar 11, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmlrt I checked that filebeat is now deployed as daemonset. With this change now we are covering that case, and the tests pass

@mdelapenya mdelapenya marked this pull request as ready for review March 11, 2021 16:40
jmlrt
jmlrt approved these changes Mar 15, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@jmlrt jmlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM⛴

Comment thread .ci/Jenkinsfile Outdated
string(name: 'HELM_CHART_VERSION', defaultValue: '7.10.0', description: 'SemVer version of Helm chart to be used.')
string(name: 'HELM_VERSION', defaultValue: '3.4.1', description: 'SemVer version of Helm to be used.')
string(name: 'HELM_KIND_VERSION', defaultValue: '0.8.1', description: 'SemVer version of Kind to be used.')
string(name: 'HELM_CHART_VERSION', defaultValue: '7.11.1', description: 'SemVer version of Helm chart to be used.')
Copy link
Copy Markdown
Member

@jmlrt jmlrt Mar 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7.11.2 has been released last week

Copy link
Copy Markdown
Contributor Author

@mdelapenya mdelapenya Mar 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, let's update this PR then

mdelapenya
mdelapenya commented Mar 15, 2021
View reviewed changes
Comment thread .ci/Jenkinsfile Outdated
mdelapenya
mdelapenya commented Mar 15, 2021
View reviewed changes
Comment thread e2e/_suites/helm/README.md Outdated
mdelapenya
mdelapenya commented Mar 15, 2021
View reviewed changes
Comment thread e2e/_suites/helm/helm_charts_test.go Outdated
jmlrt
jmlrt approved these changes Mar 15, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@jmlrt jmlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM⛴

@mdelapenya mdelapenya merged commit 15ce26d into elastic:master Mar 16, 2021
mdelapenya added a commit to mdelapenya/e2e-testing that referenced this pull request Mar 16, 2021
@mdelapenya
chore: bump helm versions (elastic#874)
ab41e14 
* chore: bump helm charts version

* chore: bump helm version

* chore: bump kind version

* fix: support filebeat deployment

elastic/helm-charts#964 introduced the feature of
deploying a Kubernetes deployment instead of a Daemonset using Filebeat,
using a values.yaml syntax equivalent to Metricbeat

* chore: update version to 7.11.2
# Conflicts:
#	.ci/Jenkinsfile
@mdelapenya mdelapenya mentioned this pull request Mar 16, 2021
Merged
mdelapenya added a commit to mdelapenya/e2e-testing that referenced this pull request Mar 16, 2021
@mdelapenya
chore: bump helm versions (elastic#874)
c3e8420 
* chore: bump helm charts version

* chore: bump helm version

* chore: bump kind version

* fix: support filebeat deployment

elastic/helm-charts#964 introduced the feature of
deploying a Kubernetes deployment instead of a Daemonset using Filebeat,
using a values.yaml syntax equivalent to Metricbeat

* chore: update version to 7.11.2
# Conflicts:
#	.ci/Jenkinsfile
@mdelapenya mdelapenya mentioned this pull request Mar 16, 2021
Merged
mdelapenya added a commit to mdelapenya/e2e-testing that referenced this pull request Mar 16, 2021
@mdelapenya
chore: bump helm versions (elastic#874)
695f211 
* chore: bump helm charts version

* chore: bump helm version

* chore: bump kind version

* fix: support filebeat deployment

elastic/helm-charts#964 introduced the feature of
deploying a Kubernetes deployment instead of a Daemonset using Filebeat,
using a values.yaml syntax equivalent to Metricbeat

* chore: update version to 7.11.2
# Conflicts:
#	.ci/Jenkinsfile
@mdelapenya mdelapenya mentioned this pull request Mar 16, 2021
Merged
mdelapenya added a commit that referenced this pull request Mar 16, 2021
@mdelapenya
chore: bump helm versions (#874) (#896)
b9d5a4b 
* chore: bump helm charts version

* chore: bump helm version

* chore: bump kind version

* fix: support filebeat deployment

elastic/helm-charts#964 introduced the feature of
deploying a Kubernetes deployment instead of a Daemonset using Filebeat,
using a values.yaml syntax equivalent to Metricbeat

* chore: update version to 7.11.2
# Conflicts:
#	.ci/Jenkinsfile
mdelapenya added a commit that referenced this pull request Mar 16, 2021
@mdelapenya
chore: bump helm versions (#874) (#898)
d0a0103 
* chore: bump helm charts version

* chore: bump helm version

* chore: bump kind version

* fix: support filebeat deployment

elastic/helm-charts#964 introduced the feature of
deploying a Kubernetes deployment instead of a Daemonset using Filebeat,
using a values.yaml syntax equivalent to Metricbeat

* chore: update version to 7.11.2
# Conflicts:
#	.ci/Jenkinsfile
mdelapenya added a commit that referenced this pull request Mar 16, 2021
@mdelapenya
chore: bump helm versions (#874) (#897)
c53716c 
* chore: bump helm charts version

* chore: bump helm version

* chore: bump kind version

* fix: support filebeat deployment

elastic/helm-charts#964 introduced the feature of
deploying a Kubernetes deployment instead of a Daemonset using Filebeat,
using a values.yaml syntax equivalent to Metricbeat

* chore: update version to 7.11.2
# Conflicts:
#	.ci/Jenkinsfile
@mdelapenya mdelapenya deleted the 747-bump-helm branch March 16, 2021 16:24
v1v added a commit to v1v/e2e-testing that referenced this pull request Mar 17, 2021
@v1v
Merge remote-tracking branch 'upstream/master' into feature/monitor-t…
15aaf3f 
…hings

* upstream/master:
  fix: generate a jUnit file per test suite (elastic#907)
  chore: rename slack channel for Fleet's nightly build (elastic#899)
  chore: do not scan 6.8.x branch (elastic#879)
  chore: bump helm versions (elastic#874)
@mdelapenya mdelapenya mentioned this pull request Oct 26, 2021
Merged
8 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@cachedout cachedout cachedout approved these changes

@jmlrt jmlrt jmlrt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mdelapenya mdelapenya

Labels

helm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bump observability helm charts

4 participants

@mdelapenya @elasticmachine @cachedout @jmlrt